fix(stimulus): don't require an optional dependency if it's not used #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2020
Closed
|
(rebased) |
|
Thank you @Kocal! |
|
Thanks @Kocal, amazing you've been so quick! |
|
Thanks to you 😳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #861
Testing my modification on a new Symfony repository but removing
@symfony/stimulus-bridgeandstimulusdependencies.If you try to use
.useStimulusBridge()without those depdendencies installed, you now have this friendly error message:When you install the dependencies, everything is okay:
When you don't use
.useStimulusBridge()and don't have installed Stimulus dependencies, you have no errors anymore about those missing deps, since they are not required.Here, the errors are coming from the app code (from the Symfony recipe) I didn't have update, but it's fine:
cc @fabpot @weaverryan